search

PaulBatchelor / voc

A physical model of the human vocal tract using literate programming, based on Pink Trombone.
https://paulbatchelor.github.io/proj/voc
149 stars 10 forks source link

Missing tongue_amplitude update #16

Open dkadish opened 5 years ago

dkadish commented 5 years ago

https://github.com/PaulBatchelor/voc/blob/20a17d66b178d1e05b8e3d96c61f6f22e79fb1f6/top.w#L224-L239

I think that an update to tongue_amplitude is missing in line 234-235. In line 226, it is updated using the value of fixed_tongue_diameter, but within the loop, the new value of fixed_tongue_diameter goes unused as tongue_amplitude is not updated...

dkadish commented 5 years ago

On second thought, I think you can actually just remove line 234. Both fixed_tongue_diameter and tongue_amplitude are not being updated in the loop, so it is unnecessary....

PaulBatchelor commented 5 years ago

Thanks! Could you make a PR for this fix? Thanks.