PaulBatchelor / voc

A physical model of the human vocal tract using literate programming, based on Pink Trombone.
https://paulbatchelor.github.io/proj/voc
149 stars 10 forks source link

Remove unused "new_diameter" array. #9

Closed belm0 closed 6 years ago

belm0 commented 6 years ago

bug from PT

belm0 commented 6 years ago

Actually, rest_diameter isn't used either. But rather than an inherited bug, in this case it's a consequence of voc lacking PT's high level constriction management. In PT, on every UI cycle, target_diameter is overwritten with rest_diameter (which incorporates tongue position), then the currently active constrictions are applied.

I'll be taking a stab at adding constriction management soon.