PaulBrack / Yamato

SWATH-QC metrics
Apache License 2.0
1 stars 1 forks source link

Option 'z, cacheSpectraToDisk' does not evaluate as positive if present but not set to true #128

Closed mwalzer closed 4 years ago

mwalzer commented 4 years ago

From --help, option z looks like a flag but using it like one yields

Singularity> SwaMe.Console -z -i split_napedro_L120420_010_SW-400AQUA__human_2ul_dilution_1_1.nf.pp.mzML  
SwaMe.Console 1.0.0
Copyright (C) 2020 SwaMe.Console

ERROR(S):
  Option 'z, cacheSpectraToDisk' has no value.

Am I supposed to set it to true? Seems that is working in so far as I get to the ouput described in #127

marinaPauw commented 4 years ago

Hello! Yes, the idea is to specify a bool after so: -z true or -z false.

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Mon, Mar 2, 2020 at 12:27 PM Mathias Walzer notifications@github.com wrote:

From --help, option z looks like a flag but using it like one yields

Singularity> SwaMe.Console -z -i split_napedro_L120420_010_SW-400AQUA__human_2ul_dilution_1_1.nf.pp.mzML SwaMe.Console 1.0.0 Copyright (C) 2020 SwaMe.Console

ERROR(S): Option 'z, cacheSpectraToDisk' has no value.

Am I supposed to set it to true? Seems that is working in so far as I get to the ouput described in #127 https://github.com/PaulBrack/Yamato/issues/127

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PaulBrack/Yamato/issues/128?email_source=notifications&email_token=AKP4IQ4OWIWBUF5FFKDQPKDRFOCYXA5CNFSM4K7RGKVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRUTKOA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKP4IQ5WHIRMGC7DLP7KAS3RFOCYXANCNFSM4K7RGKVA .

PaulBrack commented 4 years ago

@mwalzer agreed that the behaviour of this variable requiring an argument is confusing - this should default to false and evaluate to true on presence

PaulBrack commented 4 years ago

@mwalzer amended in 81f2a908936a1f346ef5a6e2d93b9f24198875b6