PaulBrack / Yamato

SWATH-QC metrics
Apache License 2.0
1 stars 1 forks source link

When publishing standalone Linux binaries, publish the "publish" directory not the base directory #137

Closed Ozzard closed 4 years ago

Ozzard commented 4 years ago

At present, the packaging of the standalone Linux distribution puts the standalone in a "publish" subdirectory, which is confusing as the parent contains similar binaries that are not runnable standalone.

Ideally, we would only publish the standalone rather than its parent directory, and we would modify the container creation scripts to handle this change.

Happy to tackle this if I can get permission to amend jobs on the repo.

PaulBrack commented 4 years ago

@Ozzard can you confirm this works as expected?

Ozzard commented 4 years ago

This is as expected; interestingly, everything's in a single executable. Worth keeping the zip file in case we want to add docs and data files, I think.

PaulBrack commented 4 years ago

@Ozzard the single file was an active decision - see build switch -p:PublishSingleFile=true

Zip file is a neccessity - it's how the publish tool works