search

PaulBrack / Yamato

SWATH-QC metrics
Apache License 2.0
1 stars 1 forks source link

A file called "c:\temp\nlog-internal.log" is always created #82

Closed mwalzer closed 4 years ago

mwalzer commented 4 years ago

with the standalone dotnet version, tested on linux. Might be a hint at hardcoded parameters? I'd suggest something likepublic static string GetTempFileName (); or public static string GetTempPath ();

PaulBrack commented 4 years ago

This is hardcoded in nlog's config - applied fix on commit efaaad894be0422c24dcd25cac19a565fa3c515d

PaulBrack commented 4 years ago

Happy to let the internal log file fall into the executable folder so closing

Ozzard commented 4 years ago

Can I suggest using ${tempdir}/nlog-internal.log, per https://github.com/NLog/NLog/wiki/Internal-Logging ? File creation in an application's directory has been a MUST NOT since Windows 2000, as applications installed in Program Files will not have write access to their installation directories.

PaulBrack commented 4 years ago

Didn't think about this going into Program Files as we're building it as standalone,, happy to put somewhere else

PaulBrack commented 4 years ago

As we're moving the log file outside Yamato, I've changed this to ${tempdir}/Yamato_nlog-internal.log so people know where it's coming from