PaulBratslavsky / nextjs-build-in-public

https://nextjs-build-in-public.vercel.app
27 stars 10 forks source link

Public Chat #1

Open paulnotfromstrapi opened 1 year ago

paulnotfromstrapi commented 1 year ago

Share your thoughts and ideas and recommendations for this project.

paulnotfromstrapi commented 1 year ago

Hello everyone

PaulBratslavsky commented 1 year ago

hello

ztxone commented 1 year ago

Need more data to work with )

PaulBratslavsky commented 1 year ago

@ztxone we are just starting out. So still in planing phase. Did you watch the stream. We outlined some of the project basics requirements.

We want to build an Events management website. We are still in planning phase. Areas we are looking for help

Design for Pages

Once we have the basic designs we will structure the data.

I just added PR for typescript support to be able to use Strapi types in the Next JS frontend.

Next step is to design the Front page. We were thinking of keeping it simple. Hero section. List of upcoming events. And in the hero section have a link to login/register page.

Once we have the home page, start working on Register Page and login in page. We will keep it simple to start.

we will use email, username and password to register

and login will be done with an identifier ( email/username) and password.

We will receive a JWT token from Strapi so will have to figure out how to stroe it in session storage

In terms of how to handle form submission. I know we can use client components. But I was curios of possibly using server actions. Still up for debate.

Let me know if this helps. Or any suggestion you may have.

wongprom commented 1 year ago

Hi all! Just wanted to drop by and drop some ❤️ for this project and hopefully try to contribute to this project. I have a PR template that may be helpful for this project; you can, of course, tweak it as needed. btw ,You may know me as Jimmy Wongprom Bäckström from the Youtube Live Stream

PR Template Status Type Env Vars Change Review App Ticket
Ready/Hold Feature/Bug/Tooling/Refactor/Hotfix Yes/No [Link]() [Link]()

⚠️ NOTE: use notes like this to emphasize something about the PR. This could include other PRs this PR is built on top of; new or removed environment variables; reasons for why the PR is on hold; or anything else you would like to draw attention to.

Problem

What problem are you trying to solve?

Solution

How did you solve the problem?

Before & After Screenshots

BEFORE: [insert screenshot here]

AFTER: [insert screenshot here]

Other changes (e.g. bug fixes, UI tweaks, small refactors)

Deploy Notes

Notes regarding deployment of the contained body of work. These should note any new dependencies, new scripts, etc.

New environment variables:

New scripts:

New dependencies:

New dev dependencies:

Checklist

General

ztxone commented 1 year ago

Let me know if this helps. Or any suggestion you may have.

Thank for details!

How do you plan to sync starpi data between contributors? technically now everyone have it's own instance of strapi-data on localhost...

Boegie19 commented 1 year ago

we should probebly have an export of some test data in the repo itself so you can import it when you need to have data. only issue would if 2 people update the zip it would be merge comflicts that can't be fixed.

ztxone commented 1 year ago

we should probebly have an export of some test data in the repo itself so you can import it when you need to have data. only issue would if 2 people update the zip it would be merge comflicts that can't be fixed.

Yes, think so too. And one else problem:

after cloning repo i don't have any env variables and even after yarn & yarn build (in backend directory) i can't start backend... so do i need to totally rebuild strapi from 0 for me or it has some ability to copy same vars like APP_KEYS API_TOKEN_SALT etc to my localhost?

ztxone commented 1 year ago

one else thing after strapi export command - i guess strapi exports admin user too, isn't it? so when i will import exported data i will need same admin account to strapi admin panel?

PaulBratslavsky commented 1 year ago

@ztxone i will create some data to seed the db.

The only issue with this is that when ever someone makes a PR with change, especially where you add new fields and data, you would have to update seed file. Which is fine, lol as long as we remember to update.

Also I just did a pr to add type support, and noticed that .env.example is missing.

So I added it back.

Will merge the pr today.

PaulBratslavsky commented 1 year ago

@wongprom thanks for sharing the template. I will add it.

PaulBratslavsky commented 1 year ago

I have added few todos in the issues, feel free to work on some.

ztxone commented 1 year ago

Made another PR. Correct me if i make something wrong about PRs... a bit newbie in that)

PaulBratslavsky commented 1 year ago

@ztxone no worries. I ended up changing few things in your initial PR to make rendering images easier when pulling from Strapi. But I ended up merging those changes late last night. So I think I created conflicts in the Main branch vs your new PR.

I will look to update. Also, have you ever done a rebase before?

And also, I am fairly new to managing public projects with multiple contributors, so it's a learning lesson for me too.

ztxone commented 1 year ago

I see. There is a problem for me with permissions to your repo. So i was asked for fork you repo cuz i don't have rights to commit original branches. This case is new for my experience too )) usually my account adds to repo as a contributor, so i'm working with same repo but in my own branch. This way causes no problem with PR and merge. At this point idk what to do with your commits on my fork and how it will be handled. Will try to do experiments)

And as far as i know rebase is able around my forked repo...not repo forked from. But i may be wrong about that

PaulBratslavsky commented 1 year ago

@ztxone you can ignore, I ended up creating a branch with your changes and merging that instead. So moving forward, just pull the new code to your main branch on you local computer and start from there.

I made the updates here https://github.com/PaulBratslavsky/nextjs-build-in-public/pull/29

Also I will be hanging out in Discord https://discord.com/invite/strapi 12:30 CST - 1:50 PM CST in Strapi's Open Office Hour Chat, cant stop by if available, I can walk you through all the current changes.

PaulBratslavsky commented 1 year ago

@ztxone I again messed up. I realized what I was doing wrong. I forgot fork your PR and fetch locally and make changes directly in your PR. But I now know what I was doing wrong.

I fixe the issue you were having. There is a 'bug' in the type that you were using.

I replaced it with a custom type. But that is what was throwing you off.

I pulled your changes into this branch.

Also just a note. Every time you start a new branch, make sure you pull all the data from main branch so you are always working from the most recent code.

This is something I am learning to.

Your design looks great. Awesome job as always. update

https://github.com/PaulBratslavsky/nextjs-build-in-public/pull/34

ztxone commented 1 year ago

Yep, need to refactor list-item a bit to my mind )

upd: made a beauty EventCard )) check PR, please )

upd2: i supposed this time i've done correct PR ?

PaulBratslavsky commented 1 year ago

Lol you were doing everything right. It was me pulling your PR to my main rather then fetching your remote repo.

And having the code current with the new changes makes a big difference thank you.

I think this is the next good page to work on https://github.com/PaulBratslavsky/nextjs-build-in-public/issues/20 @ztxone you are doing a really good job. I appreciate it. Thank you.🙂

PaulBratslavsky commented 1 year ago

@ztxone thank you for all your awesome help. I am still trying to figure out how to add image via sever actions in next. Before I can finish profile and add event pages.

In terms of UI, you can work on this issue https://github.com/PaulBratslavsky/nextjs-build-in-public/issues/19

Let me know if you have any questions.

And once again thank you for the help.

PaulBratslavsky commented 1 year ago

@ztxone i did add changes to the events page, but I am using the same card component. But we can change it to the updated card. I just wanted to make the fetch request to events page.

PaulBratslavsky commented 1 year ago

@ztxone I am slowly making progress: a bunch of Strapi side of things that need to be done. I just updated the events page to pull the image, title, and description from strapi. It now renders the Markdown found in the content field that I added.

The markdown css found in global.css has the css responsible for the styling of the markdown. Feel free to improve the styling.

demo-markdown

When pulling the changes, you will need to run

  yarn setup
  yarn import 

To install new packages and get the new seed data.

Feel free to work on it. If you have other suggestions or UI improvements, feel free to share.

PaulBratslavsky commented 1 year ago

@ztxone new updates look awesome. Thank you.

Screenshot 2023-11-12 at 1 45 08 PM
PaulBratslavsky commented 1 year ago

@ztxone completely random, would you ever want to come on my YT channel and teach me some vue js?

In terms of this project. I am almost done with the Strapi side of things on this app.

Then, we want to test the functionality that we currently have, do final fixes, and deploy it as alpha for public users to play with.

I also made some changes to the table and filtering; we now have one table, and you can use search to filter. I considered adding buttons to filter "DRAFT, PUBLIC, or ARCHIVED."

If you want ( have time ), you can do the final UI check for V1 and make any changes you feel make sense.

And a huge thank you for all your help. You are awesome.

ztxone commented 1 year ago

@ztxone completely random, would you ever want to come on my YT channel and teach me some vue js?

Yes, sure! Why not ) BTW we can try to build another frontend for this build-in-public project but with Nuxt3 ))) This showcase is good for HeadlessCMS.

If you want ( have time ), you can do the final UI check for V1 and make any changes you feel make sense.

Yes, definitely i should see your last changes, cuz i have some commits in my fork, but not PR'ed yet. Last week was small free time actually( i'm sorry for that

PaulBratslavsky commented 1 year ago

I like the idea of rebuilding it with Vue JS. That will be awesome—also, no need to apologize. I appreciate all the help you have already given.

Also, I hope I did not break things too much for your PRs with all the changes I have made.😅.

ztxone commented 1 year ago

Also, I hope I did not break things too much for your PRs with all the changes I have made.😅.

i'm always afraid of it when do PRs )))) While i'm working on my branch and there are a lot of another commits from other developers) I'm imaging how difficult is merging PR in this case!

PaulBratslavsky commented 1 year ago

Yeah, I have the same fear. When you make the PR, I will rebase it with the main review manually and go from there. Lol. Part of it is my fault; I made lots of changes. So I did it to myself. But it will be fine.🙂