Tests are needed - Githubissues

PaulC91 / shinyauthr

R package with shiny authentication modules

https://paulc91.github.io/shinyauthr/

Other

428 stars 81 forks source link

Tests are needed #30

Closed andodet closed 3 years ago

andodet commented 4 years ago

Thanks a lot for the package, with some basic db logic to store/retrieve user credentials it has become my go-to to implement basic auth in Shiny.

I think unit tests are needed to guard the package from bugs, testthat is probably your best go-to on this one.

PaulC91 commented 4 years ago

Thanks, glad you find the package useful. I want to submit to CRAN at some point and was planning to add some tests before doing that. I don't have a lot of spare time at the moment though so PRs would be very welcome!

andodet commented 4 years ago

Added a few basic tests in this pull request.

PaulC91 commented 3 years ago

closed with #52