avoid a subshell+dirname on every compile

PaulCombal / SamRewritten

Steam Achievement Manager For Linux. Rewritten in C++.

GNU General Public License v3.0

334 stars 32 forks source link

avoid a subshell+dirname on every compile #104

Closed vapier closed 2 years ago

vapier commented 2 years ago

The $(@D) variable is defined by POSIX and GNU Make to be the dirname part of $@. So it's equivalent to dirname $@, but faster & cheaper.

vapier commented 2 years ago

every commit i send you i've tested with make clean && make -j && ./bin/launch.sh. if there's something else, lmk.

PaulCombal commented 2 years ago

Oh no it's just that I'm not testing and there's no CI/CD, so I review and assume everything works without guarantee. This is a hobby project so it's ok in the end

EDIT: Thanks for contributing :)

vapier commented 2 years ago

you're not getting paid for this !? ;)

PaulCombal commented 2 years ago

Haha I wish! Sometimes passion drives people to do crazy things out of nowhere