CLI idle exit with success

[DeadStarlin]

This one is tricky, cause when idling, and you break with SIGINT CTRL+C, you get message that pipe broke - even you should exit successfully. I tried to find issue and looks like some issues not catching correctly SIGINT is fixed by new method and to not have message just need to exit successfully and game exists by itself without error. Cause read_count was called and EXIT successfully in handle_sigint_cli not had chance to execute. Maybe you have another idea how to fix it. It does not break anything and on SIGINT won't show popup with error. Game is quitted and there are no processes left.

[PaulCombal]

I can't test right now, what OS are you using and are you positive this works?

[DeadStarlin]

Right now Linux Debian (PopOs distro).

[PaulCombal]

Alright I'll believe you on that one, hope it'll work for everyone

[PaulCombal]

Do you have other PRs pending?

[DeadStarlin]

Do you have other PRs pending?

No, nothing more now. If I'll have free time, I'll look into "next release" to-do list.

[PaulCombal]

Ok, then don't forget to @ me when you think you're done so that I will merge everything into master :)

[DeadStarlin]

Ok, then don't forget to @ me when you think you're done so that I will merge everything into master :)

@PaulCombal I think for now you can move code to master. If you can't build the release, I can do it on my side and upload it, so you can attach it to releases.

[PaulCombal]

Yess, can you build an Appimage? I'll pin it to the releases tab if that works on my end

[DeadStarlin]

SamRewritten-b50966a-x86_64.zip Here is AppImage - I had to zip it cause GitHub won't allow me to attach it otherwise.

[PaulCombal]

Doesn't run on Ubuntu 20.04:

/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.13' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libcurl.so.4)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libcurl.so.4)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libgtk-3.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libgdk-3.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libgmodule-2.0.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libssh.so.4)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libpsl.so.5)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libcrypto.so.3)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libcrypto.so.3)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libgssapi_krb5.so.2)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libldap-2.5.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libldap-2.5.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libzstd.so.1)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libcairo.so.2)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libepoxy.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libxkbcommon.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libunistring.so.2)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libunistring.so.2)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libgnutls.so.30)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libgnutls.so.30)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libkrb5.so.3)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libkrb5.so.3)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libk5crypto.so.3)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libkrb5support.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libkrb5support.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libsasl2.so.2)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libdbus-1.so.3)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libdbus-1.so.3)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libsystemd.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libsystemd.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libsystemd.so.0)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/liblzma.so.5)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/liblzma.so.5)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libcap.so.2)
/tmp/.mount_SamRewWjfjhQ/usr/bin/samrewritten: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /tmp/.mount_SamRewWjfjhQ/usr/bin/../lib/libgcrypt.so.20)

I guess we need to fix the packaging before releasing..

[DeadStarlin]

Hmm, I just checked content of package (since it's zipped) and got all dependencies there in /usr/lib... I will set up a clean VM with Ubuntu to check what is going on.

Update - I installed fresh Ubuntu 22 LTS on VM, installed Steam and fuse with lib to run appimage, and it works. Maybe GitHub did something to file: https://www44.zippyshare.com/v/entzQ1xo/file.html

[PaulCombal]

It has to do with the version of glibc installed on the host system. I don't have extensive knowledge about how it works when it comes to building and distributing AppImages but if yours only works on newer systems only, then I think it's better to pin it in a popular issue. Let's make a release only when the CI/CD pipelines are correctly set up.

[RealCelticGamer]

SamRewritten-b50966a-x86_64.zip Here is AppImage - I had to zip it cause GitHub won't allow me to attach it otherwise.

Will this work on the Steam Deck?

[ZeraX7]

SamRewritten-b50966a-x86_64.zip Here is AppImage - I had to zip it cause GitHub won't allow me to attach it otherwise.

Hi. This used to work flawlessly on Steam Deck until yesterday. Now it doesn't work at all. Could you please make a new Appimage? I'm not really good with Linux.