search

PaulCombal / SamRewritten

Steam Achievement Manager For Linux. Rewritten in C++.
GNU General Public License v3.0
344 stars 33 forks source link

[CI] Build AppImage #149

Closed qurious-pixel closed 1 year ago

qurious-pixel commented 1 year ago

Create AppImage artifact Exclude libgmodule fixes undefined symbol: g_module_open_full

Fixes https://github.com/PaulCombal/SamRewritten/issues/100

PaulCombal commented 1 year ago

Out of curiosity, can you explain why is --appimage-extract-and-run necessary on linuxdeploy?

qurious-pixel commented 1 year ago

Out of curiosity, can you explain why is --appimage-extract-and-run necessary on linuxdeploy?

In containers, it needs the libfuse2 module installed. It is easier in Docker/Github Actions to extract-and-run, thus not needing the dependency. It works locally as well, so it is a good solution.

Or you can check whether it is in a container, and run it only then.

PaulCombal commented 1 year ago

Thank you very much for contributing! I will merge this into master very soon