PaulCombal / SamRewritten

Steam Achievement Manager For Linux. Rewritten in C++.
GNU General Public License v3.0
341 stars 32 forks source link

Implement "About" menu / popup #21

Closed telans closed 4 years ago

telans commented 4 years ago

Would make the "About" selection functional within the popover menu.

Perhaps something like this? I don't know how to implement it into SamRewritten, however.

0-Screenshot_20191020_233945

wgpierce commented 4 years ago

Yeah that looks great! It's not too hard to hook it up. Using glade, give it a signal handler and hook it up similar to how the "Refresh Games" button and main_window act. Also add a delete-event, so the about box doesn't get destroyed on close. If you'd like to, make a pull request with those, and I'll accept it! It'd be a good first core coding contribution :smiley:

If you don't want to, let me know and can do it instead.

telans commented 4 years ago

Well, I'm trying to do it with gtk_show_about_dialog() but I'm not getting anywhere. I really should learn the basics... It'll be good to see what you end up doing, for where I'm going wrong

Here's the glade file with the window: aboutwindow.patch.txt

Also needed to shrink the icon to 50%, so here's that: icon

Thanks

wgpierce commented 4 years ago

If you made it in glade, you can just hook up the "About" button to a signal handler on clicked, then plumb that signal handler to call gtk_widget_show(GTK_WIDGET(m_about_dialog)) after it's constructed during MainPickerWindow::MainPickerWindow() .