PaulCombal / SamRewritten

Steam Achievement Manager For Linux. Rewritten in C++.
GNU General Public License v3.0
340 stars 32 forks source link

Changes to README, added a generic PKGBUILD, added AppImage building #23

Closed PaulCombal closed 4 years ago

PaulCombal commented 4 years ago

let me know what you think :)

telans commented 4 years ago
[telans@desktop SamRewritten]$ make
make: '/bin/samrewritten' is up to date.
[telans@desktop SamRewritten]$ 

I assume this isn't meant to happen?

No samrewritten in bin/

In Makefile,

instead of $(MAKE_PATH)/bin/samrewritten: , ${CURDIR}/bin/samrewritten: works for some reason. Same directory.

PaulCombal commented 4 years ago

You're right @telans , it's a bug there, I'll try to fix it

telans commented 4 years ago

This is just personal preference on my part, but maybe keep all the .gitignore's condensed into one in the main directory? I would also change the ignore from samrewritten*.tar.xz to samrewritten*.tar* for different compressions.

PaulCombal commented 4 years ago

Will do, thanks again for your suggestions!

telans commented 4 years ago

Regarding that last commit @PaulCombal I think I messed up the suggestion, I didn't know it would automatically commit it. There's an extra exit 1 & fi. Apologies

PaulCombal commented 4 years ago

Ok everything is fixed and working, I'll just wait for more @wgpierce review for now. Thanks telans for all the inputs! Please tell us if you find anything else :)

wgpierce commented 4 years ago

What's up with the "Submodule SamRewritten added at 9486d6" under package? Remove that probably

wgpierce commented 4 years ago

This is just personal preference on my part, but maybe keep all the .gitignore's condensed into one in the main directory? I would also change the ignore from samrewritten*.tar.xz to samrewritten*.tar* for different compressions.

I agree with this

PaulCombal commented 4 years ago

I think I fixed everything, do you have any other things to point out?

PaulCombal commented 4 years ago

I didn't agree on everything from your Readme, so I made good compromises I think. Isn't this the best Readme in the world yet @telans ?

telans commented 4 years ago

absolutely marvelous