Closed PaulCombal closed 4 years ago
[telans@desktop SamRewritten]$ make
make: '/bin/samrewritten' is up to date.
[telans@desktop SamRewritten]$
I assume this isn't meant to happen?
No samrewritten in bin/
In Makefile,
instead of $(MAKE_PATH)/bin/samrewritten:
, ${CURDIR}/bin/samrewritten:
works for some reason. Same directory.
You're right @telans , it's a bug there, I'll try to fix it
This is just personal preference on my part, but maybe keep all the .gitignore's condensed into one in the main directory? I would also change the ignore from samrewritten*.tar.xz
to samrewritten*.tar*
for different compressions.
Will do, thanks again for your suggestions!
Regarding that last commit @PaulCombal I think I messed up the suggestion, I didn't know it would automatically commit it. There's an extra exit 1
& fi
. Apologies
Ok everything is fixed and working, I'll just wait for more @wgpierce review for now. Thanks telans for all the inputs! Please tell us if you find anything else :)
What's up with the "Submodule SamRewritten added at 9486d6" under package? Remove that probably
This is just personal preference on my part, but maybe keep all the .gitignore's condensed into one in the main directory? I would also change the ignore from
samrewritten*.tar.xz
tosamrewritten*.tar*
for different compressions.
I agree with this
I think I fixed everything, do you have any other things to point out?
I didn't agree on everything from your Readme, so I made good compromises I think. Isn't this the best Readme in the world yet @telans ?
absolutely marvelous
let me know what you think :)