PaulCombal / SamRewritten

Steam Achievement Manager For Linux. Rewritten in C++.
GNU General Public License v3.0
340 stars 32 forks source link

Implement achievement selection operations #27

Closed wgpierce closed 4 years ago

wgpierce commented 4 years ago

Plumb full support for unlock all, relock all, and invert all achievements.

Bring stats/achievements naming into alignment.

Only set achievement lock unlock button as pressed when it's actually pressed/pending modification and reorient the logic around this.

Reorder signal handlers according to their order in the popup order Fix some documentation comments

Fixes #18

wgpierce commented 4 years ago

@afonsofrancof please have a look and help me test this. It works well in my testing.

afonsofrancof commented 4 years ago

I will test it tonight , thanks alot.

On Tue, Oct 29, 2019, 7:52 AM William Pierce notifications@github.com wrote:

@afonsofrancof https://github.com/afonsofrancof please have a look and help me test this. It works well in my testing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PaulCombal/SamRewritten/pull/27?email_source=notifications&email_token=ANMN4QAWDHUU5XENRBSPZ73QQ7TVDA5CNFSM4JGEW3K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECPRXQI#issuecomment-547298241, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANMN4QFEUUZY3EUNNY5VE2TQQ7TVDANCNFSM4JGEW3KQ .

PaulCombal commented 4 years ago

I'll review this tonight, but it looks good so far!

wgpierce commented 4 years ago

@telans with the last commit, now the user gets feedback on if the current game has no achievements. I think we talked about that before.

Merging this now.