PaulCombal / SamRewritten

Steam Achievement Manager For Linux. Rewritten in C++.
GNU General Public License v3.0
340 stars 32 forks source link

Some removed games won't work #41

Open PaulCombal opened 4 years ago

PaulCombal commented 4 years ago

Eg: Timelines: Assault on America

https://steamdb.info/app/234060/

https://store.steampowered.com/api/appdetails/?appids=234060 --> success: false

I don't own this game but I will have to check with other removed games if I can reproduce the issue, and see if I can do anything at all.

wgpierce commented 4 years ago

I'll post info from the reddit post here: That game seems to have been removed from Steam. The current master will now at least tell you if it couldn't retrieve achievements.

Also the app is qualified as a game in steamdb as you posted and gibbed's list. I bet it was a game at some point in the past, and the app type was never re-processed, so it stayed as a game.

felixsanz commented 4 years ago

galcon fusion is another game that was removed and it doesn't appear on SAM. it is possible to fix this? Having 50% achievements because devs remove the game and remove the multiplayer servers is not so nice :(

wgpierce commented 4 years ago

The game not showing up in the list can be worked around by providing the appId as you saw in your issue #52. The problem of multiplayer servers is the purview of your related issue #53.

Though there's still info I'd like to know about this problem since the original reporter disappeared. Steam can still launch that game, right? What do the SamRewritten logs show for this game? And does the file ~/.steam/steam/appcache/stats/UserGameStatsSchema_\<appId>.bin exist for that game?

wgpierce commented 4 years ago

@felixsanz does the game still launch on steam? Assuming it's this one https://steamdb.info/app/44200/ can you launch it by putting 44200 in the search bar then launching the one row that comes up?

felixsanz commented 4 years ago

Yea the game still launch

wgpierce commented 4 years ago

@felixsanz and it shows achievements in SamRewritten just fine? If so, then issue #50 is the same as this one. We'll probably have to adjust how games are reported. I've filed https://github.com/PaulCombal/SteamAppsList/issues/1 about this. For now, manually specifying the game is a good enough workaround.

felixsanz commented 4 years ago

Yes, achievements are shown fine if you use the App Id