search

PaulCombal / SamRewritten

Steam Achievement Manager For Linux. Rewritten in C++.
GNU General Public License v3.0
340 stars 32 forks source link

Implement All Remaining Features the Original SAM Does #61

Closed wgpierce closed 4 years ago

wgpierce commented 4 years ago

Implement only showing locked/unlocked achievements. Implement launching app in separate window.

This is branched off feat-timed-modifications so I could continue working. It'll apply cleanly on dev after feat-timed-modifications is merged to dev.

PaulCombal commented 4 years ago

Really awesome work! I can't believe you put so much effort in that, congrats! There's just the tw little things I pointed out in the review, but also about the new "timed" window, can you add a little bit of padding on the edges of the window? 5-10px let's say. Also, it looks like there would be conflicts when merging, I think this also needs to be sorted out, maybe by merging dev into the feature branch first? Other than that, fantastic! Tell me what you think

wgpierce commented 4 years ago

Can you give an example usage for CLI timed achievement unlocking under the options list on the README?

Done.

Also if you want to show it off, you can write a little paragraph about timed achievements ;)

Done. Added a "features" section too for significant features.

about the new "timed" window, can you add a little bit of padding on the edges of the window? 5-10px let's say.

Done.

Also, it looks like there would be conflicts when merging, I think this also needs to be sorted out, maybe by merging dev into the feature branch first?

Resolved.

Any other changes you want to make to the README? Do you want to bump the screenshots? I can if you want (though I use a dark theme).