Closed patriot38 closed 4 years ago
We have a choice:
I've found some icons. And with them the program looks like this:
What's ur opinion about that?
Sorry if I'm not really active during these times. Using an external icon set is a big no-no. If the icons aren't availabe on your platform, there's probably an icon package you're missing. It works on everybody's distribution except yours. I'll try booting a Fedora and messing around to see if I can solve this issue when I'll have more time.
Oh, it's only Fedora's problem? I didn't know about that, sorry.
The icons were chosen using icon names generally available on the developers' systems. No guarantee they're the best choices, I didn't look into the icon standards too closely. If you have some suggestions for more default ones that still look good, feel free to make a PR.
The icons were chosen using icon names generally available on the developers' systems. No guarantee they're the best choices, I didn't look into the icon standards too closely. If you have some suggestions for more default ones that still look good, feel free to make a PR.
I think that these icons are the best (IMO) ones in list of all built-in icons. https://github.com/PaulCombal/SamRewritten/issues/72#issuecomment-648739270
Hi again @r1ddle1 , I had time to give this issue a quick look. This has to do with the Gnome desktop icon theme, which has a very scarce icon set. Since this does not only affect Fedora users but any distro with the stock Gnome desktop, I decided to change the icons as you suggested. Here is the commit https://github.com/PaulCombal/SamRewritten/commit/14e9c792ae4aa555fa9bb16c4cd8c89cf61a74ab Let me know if you have further remarks, otherwise feel free to close the issue.
Thanks for your feedback!
Ok, now everything works correctly! Thanks for creating such an amazing app!
Solution is fine by me. Though it needs a fix to StatBoxRow.cpp too.
Hello! I'm using Fedora. I've compiled your app and it looks like this:
Can you see broken image? This is the problem!
And when I click on game I again can see broken image:
The problem is that you're trying to load icons from name that system doesn't have! See AppBoxRow.cpp line 20:
new_window_button->set_image_from_icon_name("document-export-symbolic", Gtk::BuiltinIconSize::ICON_SIZE_BUTTON);
There's no 'document-export-symbolic' in my system (Im using GNOME). Please replace icons. All icon names are described here -- https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html. Thanks! With love, r1ddle