PaulKinlan / qrcode

The best web based QR Code reader on the web
https://qrsnapper.com/
Apache License 2.0
359 stars 489 forks source link

Distribute as library ? #41

Open pacoccino opened 7 years ago

pacoccino commented 7 years ago

Hey,

Your application works like a charm, but I (and not the only one I think) would like to integrate it into my apps. Damn this work with iOS 11 finally !

Why did you distribute it as an complete web app instead of a library ? Could you package it and publish it to npm so anyone can use it ?

Thanks a lot

PaulKinlan commented 7 years ago

You can technically integrate with it because it has a callback API by putting ?x-callback-ur=yoursite in to the URL and you can get back into your app. I'm also working on a number of other intergrations via MessageChannel too.

I probably will make a library, but I didn't because I already use a library to detect the QR code...

On Mon, 14 Aug 2017 at 22:33 Pacien Boisson notifications@github.com wrote:

Hey,

Your application works like a charm, but I (and not the only one I think) would like to integrate it into my apps. Damn this work with iOS 11 finally !

Why did you distribute it as an complete web app instead of a library ? Could you package it and publish it to npm so anyone can use it ?

Thanks a lot

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PaulKinlan/qrcode/issues/41, or mute the thread https://github.com/notifications/unsubscribe-auth/AACxxs5Ipossp3cWtbAcPnHEMxaE-Y00ks5sYL0egaJpZM4O27Xf .

pacoccino commented 7 years ago

You didnt documented this feature, could you tell me port ? What it does ? POST request to to the url provided ?

I know you used a library but you wrapped it in a smart way, you have the right to make it a new library again :)

would love to be able to use this in-code with callbacks in my app. Like with https://github.com/schmich/instascan

PaulKinlan commented 5 years ago

I know this is almost two years late to reply, but it does a simple GET request.

shubham-root commented 5 years ago

I think I would also like to have this as a library too. Trying to use this in an Angular application, not sure how to go about it, any pointers?