search

PaulKinlan / qrcode

The best web based QR Code reader on the web
https://qrsnapper.com/
Apache License 2.0
363 stars 489 forks source link

Will fail when GA is blocked #47

Closed emilbjorklund closed 5 years ago

emilbjorklund commented 6 years ago

Not a huge deal, but was struggling with demo until I got the chance to hook up my iOS phone to Safari devtools and see what was going on. I have a content blocker which was blocking GA tracking, and snapping a code leads to Unhandled Promise Rejection: ReferenceError: Can't find variable: ga.

PaulKinlan commented 5 years ago

ah. Good spot. Will sort.

PaulKinlan commented 5 years ago

I originally had thought about this by gating 'ga' call because in China it took an age to resolve, but I didn't gate it correctly in strict mode.