search

PaulKuin / uvotpy

Swift UVOT grisms - spectral extraction
http://www.mssl.ucl.ac.uk/www_astro/uvot/
8 stars 5 forks source link

Trivial updates #6

Closed abostroem closed 7 years ago

abostroem commented 7 years ago

These updates don't affect the code itself, just imports and print statements

abostroem commented 7 years ago

More relative imports fixed, also issues with circular imports. No changes to code itself.

abostroem commented 7 years ago

Have you considered having 2 branches - one for the PYTHONPATH installation and one for setup.py installation?

PaulKuin commented 7 years ago

Ha, yes! and dismissed that directly as being too much of a pain. I'm not a software developer but a nutty scientist, and I think there's probably a way to do it without going to two branches. As it is in the import phase, I was considering doing something in the init file to take care of it, but have not yet completely figured out how.

On Wed, May 17, 2017 at 6:02 PM, Azalee Bostroem notifications@github.com wrote:

Have you considered having 2 branches - one for the PYTHONPATH installation and one for setup.py installation?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/PaulKuin/uvotpy/pull/6#issuecomment-302154822, or mute the thread https://github.com/notifications/unsubscribe-auth/AE67CGdN0RdSbrCtBoYfoONU3dJRMEIYks5r6ygOgaJpZM4NdVQX .

--

abostroem commented 7 years ago

This is the PR that needs to be merged still. There are a lot of changes and I made more changes since you approved it. So take a look and make sure they all make sense to you. I just tested in install and using getSpec with this week on my mac. The approve button is new, and I'm not sure what your view looks like, but I think approve and merge are separate things (and I'm hoping separate buttons). If you reopen this, I think you can merge it.

PaulKuin commented 7 years ago

resolved

PaulKuin commented 7 years ago

Well, that was interesting.

I hope that did the trick.

Cheers, Paul

On Thu, Jun 8, 2017 at 12:58 AM, Azalee Bostroem notifications@github.com wrote:

This is the PR that needs to be merged still. There are a lot of changes and I made more changes since you approved it. So take a look and make sure they all make sense to you. I just tested in install and using getSpec with this week on my mac. The approve button is new, and I'm not sure what your view looks like, but I think approve and merge are separate things (and I'm hoping separate buttons). If you reopen this, I think you can merge it.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/PaulKuin/uvotpy/pull/6#issuecomment-306959740, or mute the thread https://github.com/notifications/unsubscribe-auth/AE67CJtrqwAYvPf_opgSMOwTfw58yK1Qks5sBzklgaJpZM4NdVQX .

--