search

PaulLaux / eth-hot-wallet

Ethereum wallet with erc20 support / web wallet - built using react, web3, eth-lightwallet
https://eth-hot-wallet.com/
MIT License
300 stars 188 forks source link

Eth-hot-wallet assumes transaction is guaranteed to be executed after sending #41

Open darcher-framework opened 3 years ago

darcher-framework commented 3 years ago

Eth-Hot-Wallet

Issue Type

Description

The DApp always assumes a transfer transaction sent to Ethereum network is guaranteed to be executed. But a transaction in the pending pool can be dropped either by miners or users. But Eth-hot-wallet shows transaction success after the transaction is sent but not executed. image

Steps to reproduce

  1. Send a transaction using eth-hot-wallet.
  2. Before the transaction is executed/mined, use metamask send another transaction with same nonce but higher gasPrice.
  3. The transaction sent by eth-hot-wallet is dropped but eth-hot-wallet still shows the transaction succeeds.

Versions