PaulLeCam / react-leaflet

React components for Leaflet maps
https://react-leaflet.js.org
Other
5.13k stars 884 forks source link

UglifyJS warnings #170

Closed ayozebarrera closed 8 years ago

ayozebarrera commented 8 years ago

There are some warnings on your code:

Side effects in initialization of unused variable map [./~/react-leaflet/lib/CanvasTileLayer.js:39,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/Circle.js:46,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/CircleMarker.js:46,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/FeatureGroup.js:38,0]
Side effects in initialization of unused variable props [./~/react-leaflet/lib/FeatureGroup.js:40,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/GeoJson.js:42,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/ImageOverlay.js:46,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/Marker.js:45,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/MultiPolygon.js:45,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/MultiPolyline.js:45,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/Polygon.js:45,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/Polyline.js:43,0]
Side effects in initialization of unused variable children [./~/react-leaflet/lib/Popup.js:47,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/Popup.js:48,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/Rectangle.js:44,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/TileLayer.js:41,0]
Side effects in initialization of unused variable map [./~/react-leaflet/lib/WMSTileLayer.js:41,0]
PaulLeCam commented 8 years ago

Yes these are warnings from UglifyJS optimisations, is there a problem with it?

ayozebarrera commented 8 years ago

Problem... not.. but maybe you could clean it? or do you need those unused variables?

PaulLeCam commented 8 years ago

Updated in v0.12, the warnings are now hidden.