PaulLeCam / react-leaflet

React components for Leaflet maps
https://react-leaflet.js.org
Other
5.18k stars 888 forks source link

Circle editable in not working #601

Closed oshin23 closed 5 years ago

oshin23 commented 5 years ago

Bug report in v2

Reactjs: 16.5.1 React-leaflet: 1.8.2 React-leaflet-draw: 0.18.0

Expected behavior

When I use editable then circle should be editable.

Actual behavior

When I use editable then page going black in my laptop. it's working fine with other laptop which have same npm version(v6.4.1) but in my system it throws below error.

Screenshot 2019-07-10 at 12 07 15 PM

Steps to reproduce

I use this circle editable code

      <FeatureGroup>
        <EditControl>
     <Circle
            key={editFeatureGroup ? "circle1" : "circle2"}
            center={circleCoordinate}
            radius={geofenceRadius}
            editable
          />
  </FeatureGroup>
        </EditControl>

Macbook air OS version: 10.14.5

hugobarragon commented 5 years ago

Hello can you provide a link to check it out? i really dont see that editable option on leaflet circle docs, maybe its a bug with React-leaflet-draw instead of react-leaflet btw you have the component tags exchanged :

<FeatureGroup>
        <EditControl>
            <Circle
            key={editFeatureGroup ? "circle1" : "circle2"}
            center={circleCoordinate}
            radius={geofenceRadius}
            editable
          />
        </EditControl> {/*  here */
</FeatureGroup>