search

PaulLereverend / NextcloudDuplicateFinder

Save some space by finding your duplicate files
GNU Affero General Public License v3.0
79 stars 16 forks source link

How are group folders handled? #53

Open EngelPika32 opened 3 years ago

EngelPika32 commented 3 years ago

As the title says, how are group folders handled (if at all)?

It appears that group folders are scanned more often than necessary – creating more load than necessary to the server. For example, when running occ duplicates:find-all then files in group folders are scanned once per user with access to the folder.

From the output of an occ duplicates:find-all -vvv:

Scanning /user1/files/media-share/huge-file.mp4

Scanning /user2/files/media-share/huge-file.mp4

Scanning /user3/files/media-share/huge-file.mp4
chrros95 commented 3 years ago

The app scans files only once - even if the folder or file is shared with a group or one or more users. The only exception of this statement occurs on files that are mounted via external storage.

Or are you referring to something other than sharing by the term "group folders"?

EngelPika32 commented 3 years ago

Sorry for my late reply. I don't mean shares, I mean folders that are accessible based on the groups you are in: https://apps.nextcloud.com/apps/groupfolders (They are "owned" by one or more groups, instead of a user.)

The only exception of this statement occurs on files that are mounted via external storage.

And even files mounted via external storage shouldn't be scanned multiple times, IMO. A server could have nearly all files in external storage. (Though, that's not my case.)

rakekniven commented 3 years ago

I would like to see an option to exclude "group folders" from scan. Should I open a different issue?