PaulLereverend / NextcloudExtract

Bring extraction to your nextcloud web interface
GNU Affero General Public License v3.0
50 stars 16 forks source link

Error extracting xxxxx.xxx #18

Open muchachagrande opened 5 years ago

muchachagrande commented 5 years ago

When I use Extract Here on the file menu it always says "Error extracting file.zip" "Can't find zip file". I testes with zip, rar an 7z.

The log says:

Error | PHP | Undefined variable: output at /var/www/nextcloud/apps/extract/lib/Controller/ExtractionController.php#173 Error | PHP | sizeof(): Parameter must be an array or an object that implements Countable at /var/www/nextcloud/apps/extract/lib/Controller/ExtractionController.php#173 Error | PHP | Undefined variable: file at /var/www/nextcloud/apps/extract/lib/Controller/ExtractionController.php#174 Error | PHP | Undefined variable: file at /var/www/nextcloud/apps/extract/lib/Controller/ExtractionController.php#178

I'm using a virtual machine under VMWare ESXi 6 with Nextcloud 16.0.1 on Ubuntu 18.04.2 LTS. I've installed an appliance from Tech & Me.

Edit: I was trying to extract a file in an external storage. Then I teste it on the root dir and it does nothing at all. Now it is not showing anything on the log. May be after I installed the rar and 7zip as you mention in the comments.

PaulLereverend commented 5 years ago

You said you tried on external storage, was it external local storage ?

When you try on root dir, can you try a zip file and make sure php zip extension is loaded (you can check it with phpinfo)

muchachagrande commented 5 years ago

I tested on external SMB storage.

According to "php -i" it says that zip extension is loaded:

Zip => enabled Zip version => 1.15.4 Libzip version => 1.1.2

I've just tryed a zip file on root and it worked, and ther I tryed again with 7z and rar, and also worked. May be I made a mistake on my first try. The problem still persists with external SMB storage. I have an external SMB storage named "data" added through Nextcloud configuration. When I use "Extract Here" on archives inside the external storage it keeps saying "Error extracting... can't find file"

PaulLereverend commented 5 years ago

This app does not currently support other external storage backend than local.

I will try to add the SMB support feature but it might take long since I don't have much free time for the moment.

muchachagrande commented 5 years ago

OK... sorry I didn't realize that external storage was not supported yet.

PaulLereverend commented 5 years ago

No problem it's all on me. In fact, external storage is supported but only if you choose local.

I will keep this issue open until I add the SMB support.

Feel free to open another one if you find another bug.

mamema commented 5 years ago

i have the same error on (for this case) created local storage. "can't find zip" file. Running nextcloud 16 on an alpine linux on docker. unrar and p7zip are installed (manually)

PaulLereverend commented 5 years ago

Is the extraction working on NC storage ?

mamema commented 5 years ago

thats what i was trying to say above. I've created a local storage on the NC Server.

PaulLereverend commented 5 years ago

Yes but you mounted it with the external_storage app right ?

mamema commented 5 years ago

hmmm :-) You got me.....so what is the correct approach here then?

PaulLereverend commented 5 years ago

Could you try on default NC storage ? I mean with no app

mamema commented 5 years ago

sorry, where do i have to do that?

PaulLereverend commented 5 years ago

Sorry I'm not verry clear.

On your instance you should have some folder which have been mounted with the external_storage app and some normal folders (for example when you create your instance it's Documents, Photos ect...). I wish that you could try on those normal folders.

mamema commented 5 years ago

unfortunately as i've running a nextcloud docker container, i've deleted those directories. Tried to google a solution to recreate those folders and failed.

PaulLereverend commented 5 years ago

Can you create an account for me so I can try by myself ?

mamema commented 5 years ago

one step forward two steps back. :-). i have managed to try local storage and i have different behaviour if i connect from external (via ngnix), then i have the reported error, if i connect to NC from internal without proxy, then something is going on, there is a endless spinning wheel where the folder icon of the zip file is. But stays there without extracting anything. So i guess i have a configuration problem somewhere else.

PaulLereverend commented 5 years ago

Is the archive heavy ? Maybe it is extracting but slowly ?

mamema commented 5 years ago

no not really, a few megs. I've found my issue regarding "internal and external behave different". This was the brutforce plugin. After whitlisting my external ip, the issue regarding "can't find zip" was gone. But the spinning wheel problem remains. In which log should i take a look about this issue? I've disabled every 3rd party app and only extract is activated.

In nginx i got the (in)famous: "2019/06/06 14:09:51 [error] 27026#27026: *27442 FastCGI sent in stderr: "Primary script unknown" while reading response header from upstream, client: xxx.xxx.xxx.xxx, server: xxx, request: "POST /nextcloud/index.php/apps/extract/ajax/extractHere.php HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/php72-fpm.sock:", host: "xxx"

PaulLereverend commented 5 years ago

Do you have php's zip extension installed and enabled ? Could you try to delete and reinstall the app ?

mamema commented 5 years ago

php -m shows zip extension. I've installed p7zip as mentioned on your homepage. To rule out nginx conf, i've implemented now the offical nginx conf from nextcloud. Same behavior. spinning wheel and error from post https://github.com/PaulLereverend/NextcloudExtract/issues/18#issuecomment-499466922

uninstall/reinstall same behaviour

PaulLereverend commented 5 years ago

Can you create an account for me with access to a single folder containing a zip file ?

It will be faster and easier for me to debug.

mamema commented 5 years ago

solved! Complete reinstall of nextcloud infrastructure. Exctract works on local storage. Thank you for your kind support. Now waiting for external_storage (SMB) extract.

PaulLereverend commented 5 years ago

Oh I'm glad to hear that ! Until I add the SMB support you can still copy the archives to your local storage, extract them and then place the files back to your SMB device.

mamema commented 5 years ago

when i mount a storage from docker (nextcloud) which is on the host where the docker image is running, qualifies this as local storage?

PaulLereverend commented 5 years ago

If you mount it on NC with the external storage app then yes it is local storage.

xyko0 commented 4 years ago

Hello Paul, Thank you for this app I have the same issue using Nextcloud S3 as primary storage :/ Would it be posible to add this feature to your app in the future ? It would be awesome. Thank you =)