PaulLereverend / NextcloudExtract

Bring extraction to your nextcloud web interface
GNU Affero General Public License v3.0
50 stars 16 forks source link

Only owner of folder can extract the files #41

Open mantri-govind opened 4 years ago

mantri-govind commented 4 years ago

Scenario : There are UserA and UserB. UserA creates folder and share it with UserB. UserB uploads a zip folder in shared folder and try to extract. Process run and nothing happens.

Expected Result : If user have full rights on shared folder, s/he should be able to extract the files.

PaulLereverend commented 4 years ago

Fixed in latest update 247a7aa. Feel free to tell me if something is not working.

mantri-govind commented 4 years ago

@PaulLereverend Thanks I'll test and get back to you :)

lmamane commented 4 years ago

Using extract version 1.2.2 with NextCloud 17.0.1.

I created a folder shared by link. When logged in as the folder owner, I can use "extract".

When accessing the folder by the link (without logging in as any user), the "extract here" doesn't appear as an option on the menu opened by clicking on "...".

PaulLereverend commented 4 years ago

@lmamane That is the expected behavior, you must be logged in to use this app.

I could look into allow guests to extract if it is a need for you.

lmamane commented 4 years ago

My expectation would be that any person that has write access to the directory (not the zip file! The directory that contains it.) can use the app. Since they can anyway achieve the same result by downloading the zip, extracting on their computer and uploading the files, using the app only gives them a more convenient way to do the same thing they are already authorised to do, which in my expectation is the whole purpose of the app.

So: