Open Valdnet opened 3 years ago
I propose to extract the space character from text strings:
https://github.com/PaulLereverend/NextcloudExtract/blob/a1cabef4547d83623fc1041cef3a923ff8dddcae/lib/Controller/ExtractionController.php#L84 https://github.com/PaulLereverend/NextcloudExtract/blob/a1cabef4547d83623fc1041cef3a923ff8dddcae/lib/Controller/ExtractionController.php#L161 https://github.com/PaulLereverend/NextcloudExtract/blob/a1cabef4547d83623fc1041cef3a923ff8dddcae/lib/Controller/ExtractionController.php#L237 https://github.com/PaulLereverend/NextcloudExtract/blob/a1cabef4547d83623fc1041cef3a923ff8dddcae/lib/Controller/ExtractionController.php#L271 https://github.com/PaulLereverend/NextcloudExtract/blob/2dea2a6c756e88ee6da6e1166584dca3e5780212/js/extraction.js#L44 https://github.com/PaulLereverend/NextcloudExtract/blob/2dea2a6c756e88ee6da6e1166584dca3e5780212/js/extraction.js#L92
This will improve the correctness of translations by translators in Transefix. Not all translators have spaces turned on in their settings, which causes them to skip the space at the end of sentences.
I propose to extract the space character from text strings:
https://github.com/PaulLereverend/NextcloudExtract/blob/a1cabef4547d83623fc1041cef3a923ff8dddcae/lib/Controller/ExtractionController.php#L84 https://github.com/PaulLereverend/NextcloudExtract/blob/a1cabef4547d83623fc1041cef3a923ff8dddcae/lib/Controller/ExtractionController.php#L161 https://github.com/PaulLereverend/NextcloudExtract/blob/a1cabef4547d83623fc1041cef3a923ff8dddcae/lib/Controller/ExtractionController.php#L237 https://github.com/PaulLereverend/NextcloudExtract/blob/a1cabef4547d83623fc1041cef3a923ff8dddcae/lib/Controller/ExtractionController.php#L271 https://github.com/PaulLereverend/NextcloudExtract/blob/2dea2a6c756e88ee6da6e1166584dca3e5780212/js/extraction.js#L44 https://github.com/PaulLereverend/NextcloudExtract/blob/2dea2a6c756e88ee6da6e1166584dca3e5780212/js/extraction.js#L92
This will improve the correctness of translations by translators in Transefix. Not all translators have spaces turned on in their settings, which causes them to skip the space at the end of sentences.