PaulLereverend / NextcloudExtract

Bring extraction to your nextcloud web interface
GNU Affero General Public License v3.0
51 stars 16 forks source link

Nothing happens when I try to extract a zip file #7

Open ntimo opened 5 years ago

ntimo commented 5 years ago

Hello, when I try to extract a zip file the NextCloud page refreshes and nothing happens. I am running Nextcloud inside of Docker with a custom image build on top of the NextCloud apache image.

Dockerfile:

FROM nextcloud:15.0.7-apache

RUN echo 'deb ftp://ftp.us.debian.org/debian/ stretch non-free \
          deb http://security.debian.org/ stretch/updates non-free \
          deb http://volatile.debian.org/debian-volatile stretch/volatile non-free' >> /etc/apt/sources.list.d/wheezy.non-free.list && \
    apt update && \
    apt-get install unrar && \
    rm -rf /var/lib/apt/lists/*

I am also using the encryption module from NextCloud which encrypts the local storage. Could this cause of the issue? Also there is no info in the log files.

PaulLereverend commented 5 years ago

Hello,

I did some tests and it looks like the issue comes from the encryption module because zip is not able to open the archive. I will see what i can do but i'm afraid it might take some time.

Sorry for that

Schmuuu commented 5 years ago

Hello,

I would like to add, that I see this issue as well, but don't use any encryption on my server. It seems the extraction is not triggered at all. There are no log entries and no messages in the browser console when clicking the "extract here" option. I'm wondering if it is related to the browser console message:

Die Ressource von "https://cloud.myserver.tld/apps/files/" wurde wegen eines MIME-Typ-Konfliktes ("text/html") blockiert (X-Content-Type-Options: nosniff)

Translated:

The resource from "https://cloud.myserver.tld/apps/files/" was blocked due to MIME type conflict ("text/html") (X-Content-Type-Options: nosniff)

This message doesn't disappear when I disable the extraction app, but I think it appeared with the last NC update to 15.0.7. Not sure if a specific module cannot be loaded, which is required by NCExtract?

Server details

PaulLereverend commented 5 years ago

Hello,

First, about the message in the console I have it too and it does not seems to cause any problem on my tests instances.

@Schmuuu is your NC inside docker ?

I'm working on adding many error messages to help debug.

Schmuuu commented 5 years ago

Hello,

No, NC is not running in docker. Bare metal.

PaulLereverend commented 5 years ago

Hello,

Okay, the next version is almost done and it will help figuring out where is the bug so I can fix it.

PaulLereverend commented 5 years ago

Hello @Schmuuu ,

I added a few error messages in this version. Could you try it and tell me if it tells you something so I can find the bug and fix it ?

Delete the plugin and extract this into nextcloud/apps https://github.com/PaulLereverend/NextcloudExtract/releases/download/1.1.5/extract.tar.gz

Schmuuu commented 5 years ago

Hi @PaulLereverend

Thank you very much for providing a new version that quick. Fun fact: it already solves the problems! 💃

There are still some error messages written to the nextcloud.log. For each zip archive I extracted, I received 5 identical messages:

{"reqId":"ABCD1234567890BtZXYZ","level":3,"time":"2019-04-26T22:13:57+02:00","remoteAddr":"123.123.123.123","user":"MyUser","app":"PHP","method":"POST","url":"\/index.php\/apps\/extract\/ajax\/extractHere.php","message":"Cannot modify header information - headers already sent by (output started at \/var\/www\/nextcloud\/apps\/extract\/lib\/Controller\/ExtractionController.php:76) at \/var\/www\/nextcloud\/lib\/private\/AppFramework\/Http\/Output.php#69","userAgent":"Mozilla\/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko\/20100101 Firefox\/66.0","version":"15.0.7.0"}

But apart from that, the app is working fine now 👍

PaulLereverend commented 5 years ago

Nice ! I made some under the hood changes that seem to have solved the problem. I think I know why that message pop up on the logs. I'll fix it on the next public release.

Do not hesitate to open another ticket if you find a new bug, i'll be happy to fix it 😉

ntimo commented 5 years ago

Do you have a update on this? :( When I try to extract a file the UI gives me this error: Can't open zip file at /data/ntimo/files/ZIP/wallpapers.zip

PaulLereverend commented 5 years ago

NC's encryption module is still not supported :(. I'm sorry, I don't have much time to work on this