search

PaulLereverend / NextcloudVideo_Converter

Video converter app for nextcloud
GNU Affero General Public License v3.0
58 stars 35 forks source link

Change OC_Mount_Config for OCA\Files_External\MountConfig #49

Closed MorrisJobke closed 3 years ago

MorrisJobke commented 4 years ago

This app should migrate for Nextcloud 20 to OCA\Files_External\MountConfig.

See nextcloud/server#21785

Also the method getExternalMP does not need to be annotated with @NoAdminRequired - it's an internal method anyways only and it can be protected as well. In there just check for either the availability of OCA\Files_External\MountConfig::getAbsoluteMountPoints (for 20+) or OC_Mount_Config:: getAbsoluteMountPoints (for everything up to 19). Also why do you need those private method calls? Best would be to not rely on internal methods private classes.

MorrisJobke commented 4 years ago

cc @PaulLereverend

PaulLereverend commented 3 years ago

Thoses methods are not used anymore on the latest update