search

PaulLereverend / NextcloudVideo_Converter

Video converter app for nextcloud
GNU Affero General Public License v3.0
58 stars 35 forks source link

Added support for group folders #60

Closed AcidCrash1337 closed 3 years ago

AcidCrash1337 commented 3 years ago

This should address issue 17 https://github.com/PaulLereverend/NextcloudVideo_Converter/issues/17 and the duplicate issue 57 https://github.com/PaulLereverend/NextcloudVideo_Converter/issues/57

I have tested this to the extent that I confirmed that it can find the file to be converted and it runs the correct ffmpeg command. It looks like there might be a need to update the call to scanFolder() as well, but I don't know the arguments it takes and since I can't test this part (see below), I didn't feel comfortable making changes which might break user folders.

Unfortunately, this plugin doesn't work for me (group folders or not) because I use a snap in order to manage Nextcloud. This results in the server operating in a chroot environment where it can not reach /usr/bin/ffmpeg.

PaulLereverend commented 3 years ago

Hi Thank you for your work ! Your PR broke the app on my test environment so I rewrote some parts starting from the master branch. The group folders now seems to work in my test environment. The new version is available here : https://github.com/PaulLereverend/NextcloudVideo_Converter/releases/tag/1.0.0 Can you confirm that it is working for you too ?

PaulLereverend commented 3 years ago

Group folders are supported in the latest update.