PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.81k stars 212 forks source link

Fix for empty incoming jobs #101

Closed PaulMcInnis closed 3 years ago

PaulMcInnis commented 3 years ago

Pull Request Template

Description

This fixes #100

Context of change

Type of change

How Has This Been Tested?

Ran demos locally.

Checklist:

Please mark any boxes that have been completed.

PaulMcInnis commented 3 years ago

Going to merge this and update 3.0.0 release once travis passes and cut a new release for this as this is a pretty massive bug.

codecov-commenter commented 3 years ago

Codecov Report

Merging #101 into master will decrease coverage by 0.10%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   36.70%   36.59%   -0.11%     
==========================================
  Files          22       22              
  Lines        1346     1350       +4     
==========================================
  Hits          494      494              
- Misses        852      856       +4     
Impacted Files Coverage Δ
jobfunnel/__main__.py 0.00% <0.00%> (ø)
jobfunnel/backend/jobfunnel.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25ce96e...b0d87ed. Read the comment docs.

PaulMcInnis commented 3 years ago

Note: I force updated our 3.0.0 tag to include this.