Open LilySu opened 4 years ago
Agreed, I think we can do away with city and perhaps also province in the url entirely if its a Fully remote search.
per discussion in #106, lets take the approach of allowing city and province/state to be None, with a default of ''
in our CSV entries when we write out jobs.
This is valid not only for explicitly remote searches, but also for users who are interested in locating jobs anywhere in a country.
I think it may also make sense to allow for globally-remote searching, but we currently dont' have the appropriate search queries for our providers (which are localised to country). I think it makes sense to leave that feature for when we implement a provider for globally-remote jobs.
For now, probably we can just add the city and make the search radius ridiculously large.
@josian good point about search radius. We may also be able to exclude it from the query URL entirely. Need to look into this.
Description
It would be great to not search by city, as even if the filter can be set for remote, the results returned are still based on city indicated.
Steps to Reproduce
funnel load -s my_settings.yaml
Expected behavior
Successfully scrape and generate .csv
Actual behavior
Traceback and ValueError if 'province_or_state' or 'city' is not included
Environment