PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.78k stars 210 forks source link

Implemented UK_ENGLISH Locale #106

Closed LilySu closed 3 years ago

LilySu commented 3 years ago

Implemented UK_ENGLISH Implemented Search

Description

Implemented UK_ENGLISH as an option for 'locale' in the same way USA_ENGLISH and CANADA_ENGLISH are implemented, except with 'co.uk' for Indeed and Monster.

This involved taking out the state or province in the URL for get_search_url in indeed.py and monster.py in subclass: IndeedScraperUKEng and MonsterScraperUKEng.

Context of change

Please add options that are relevant and mark any boxes that apply.

Type of change

Please mark any boxes that apply.

How Has This Been Tested?

Ran UK_ENGLISH in my_settings.yaml with cities in the UK such as London and Cambridge for Indeed and Monster.

Checklist:

Please mark any boxes that have been completed.

codecov-commenter commented 3 years ago

Codecov Report

Merging #106 into master will increase coverage by 0.22%. The diff coverage is 54.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   35.68%   35.90%   +0.22%     
==========================================
  Files          22       22              
  Lines        1390     1412      +22     
==========================================
+ Hits          496      507      +11     
- Misses        894      905      +11     
Impacted Files Coverage Δ
jobfunnel/backend/scrapers/registry.py 100.00% <ø> (ø)
jobfunnel/resources/defaults.py 100.00% <ø> (ø)
jobfunnel/backend/scrapers/indeed.py 28.57% <28.57%> (ø)
jobfunnel/backend/scrapers/monster.py 26.97% <44.44%> (+0.58%) :arrow_up:
jobfunnel/backend/scrapers/base.py 38.56% <75.00%> (+0.97%) :arrow_up:
jobfunnel/backend/scrapers/glassdoor.py 30.93% <100.00%> (+1.00%) :arrow_up:
jobfunnel/resources/enums.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d0297e...eb20bc5. Read the comment docs.