search

PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.78k stars 210 forks source link

Unknown Location Error #110

Closed Pittsie72 closed 3 years ago

Pittsie72 commented 3 years ago

Files.zip

Description

I have 2 identical .yaml files. Only difference is the location the information is stored and one looks for CFO positions and the other Human Resource. However, the Human Resource has the following error where as the CFO does not: Traceback (most recent call last): File "/home/pittsie/.local/bin/funnel", line 8, in sys.exit(main()) File "/home/pittsie/.local/lib/python3.8/site-packages/jobfunnel/main.py", line 28, in main job_funnel.run() File "/home/pittsie/.local/lib/python3.8/site-packages/jobfunnel/backend/jobfunnel.py", line 86, in run self.master_jobs_dict = self.read_master_csv() File "/home/pittsie/.local/lib/python3.8/site-packages/jobfunnel/backend/jobfunnel.py", line 405, in read_master_csv locale = locale.UNKNOWN AttributeError: 'NoneType' object has no attribute 'UNKNOWN'

Both files have been attached in a zip

Expected behavior

Run

Actual behavior

Error shown above only on Bill.yaml not 2Mom.yaml

Environment

Pittsie72 commented 3 years ago

Discovered it was an issue in the CSV

PaulMcInnis commented 3 years ago

Ah, yes this would seem to have been caused by an empty column in the CSV.

I think there is value in handling these errors more efficiently though, I will look into improving this.

Pittsie72 commented 3 years ago

I appreciate it!

I didn't do anything to the csv to add a blank so that's why I was very confused

On Fri, Oct 2, 2020, 9:28 AM Paul McInnis notifications@github.com wrote:

Ah, yes this would seem to have been caused by an empty column in the CSV.

I think there is value in handling these errors more efficiently though, I will look into improving this.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/PaulMcInnis/JobFunnel/issues/110#issuecomment-702734370, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANAJFZWBG4AXTKB4FA6AMKDSIXIRXANCNFSM4SBWEONQ .

PaulMcInnis commented 3 years ago

hmm that's not good, was the issue with the CSV that all it got all mixed up? I've been seeing this on my end when something in the job description isn't escaped correctly (it's comma-separated after all).

Pittsie72 commented 3 years ago

I'm not sure honestly. It looked all normal but I can send it to you if you'd like

On Fri, Oct 2, 2020, 10:19 AM Paul McInnis notifications@github.com wrote:

hmm that's not good, was the issue with the CSV that all it got all mixed up? I've been seeing this on my end when something in the job description isn't escaped correctly (it's comma-separated after all).

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/PaulMcInnis/JobFunnel/issues/110#issuecomment-702760854, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANAJFZTHHHP7BY5XJB4MWZ3SIXONLANCNFSM4SBWEONQ .

PaulMcInnis commented 3 years ago

yeah if you're comfortable please send it over, I'm trying to fix some bugs that are cropping up with CSV updating.

PaulMcInnis commented 3 years ago

(I'm most interested in the CSV that caused the failure if you still have it)

Pittsie72 commented 3 years ago

Attached is the one that caused some errors

On Fri, Oct 2, 2020, 11:22 AM Paul McInnis notifications@github.com wrote:

(I'm most interested in the CSV that caused the failure if you still have it)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/PaulMcInnis/JobFunnel/issues/110#issuecomment-702796297, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANAJFZWVE5HUFMR4QGCMOEDSIXV2FANCNFSM4SBWEONQ .

PaulMcInnis commented 3 years ago

hmm it seems like the attachment didn't make it onto the github, Feel free to send me an email @ paulmcinnis99@gmail.com with the CSV file and I'll take a look.