PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.78k stars 210 forks source link

Create python-publish.yml #112

Closed markkvdb closed 3 years ago

markkvdb commented 3 years ago

Publish package to PyPi

Description

Installating jobfunnel is done using the GitHub url but this would allow the package to also be installed from the PyPi distribution.

Context of change

Please add options that are relevant and mark any boxes that apply.

Type of change

Please mark any boxes that apply.

How Has This Been Tested?

Most important thing is to check if package successfully uploads to test-pypi.

Checklist:

Please mark any boxes that have been completed.

markkvdb commented 3 years ago

@PaulMcInnis to add jobfunnel to PyPi we need to provide the login credentials. I made an account that we can use but since you're the owner of the repo, you have to add the credentials to the secrets.

markkvdb commented 3 years ago

PyPi seems to work. Only issue seems to be showing images from the README on the PyPi homepage. @PaulMcInnis if you could send me your PyPi account then I'll add you to the repository as an owner. You should add these credentials as secrets using the names as specified in python-publish.yml.

codecov-commenter commented 3 years ago

Codecov Report

Merging #112 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   35.90%   35.90%           
=======================================
  Files          22       22           
  Lines        1412     1412           
=======================================
  Hits          507      507           
  Misses        905      905           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27fb84c...e48484b. Read the comment docs.

markkvdb commented 3 years ago

Did you create an account yet? @PaulMcInnis

PaulMcInnis commented 3 years ago

Did you create an account yet? @PaulMcInnis

Sorry out of town for a few days. Will get to this asap!

markkvdb commented 3 years ago

Did you create an account yet? @PaulMcInnis

Sorry out of town for a few days. Will get to this asap!

No worries. Enjoy!

markkvdb commented 3 years ago

Added your account. Hope all will go well once we merge this pull in the master ...

PaulMcInnis commented 3 years ago

Added your account. Hope all will go well once we merge this pull in the master ...

cool, will it push the latest release?

markkvdb commented 3 years ago

You first have to save your password and username as secrets in the repository. After, when you create a release in Github, it will run the python-publish.yml file. Hopefully resulting in an update on PyPi.

PaulMcInnis commented 3 years ago

Awesome OK, Let me create a task for myself to implement this, thanks for updating the code to support it!