PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.78k stars 210 forks source link

Removed misleading ERROR level messages #115

Closed PaulMcInnis closed 3 years ago

PaulMcInnis commented 3 years ago

Description

Many users are seeing ERROR level logs which are misleading, as this is a result of perfoming job.validate() on a job that fails our job filter, usually this one:

i.e. [2020-10-02 13:00:26,294] [ERROR] IndeedScraperUSAEng: Job failed validation: Description too short!

Context of change

This bypasses performing validation if we failed the filter.

Type of change

How Has This Been Tested?

Travis build passes. Tested locally as well.

Checklist:

Please mark any boxes that have been completed.

codecov-io commented 3 years ago

Codecov Report

Merging #115 into master will decrease coverage by 0.04%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   35.72%   35.67%   -0.05%     
==========================================
  Files          22       22              
  Lines        1447     1449       +2     
==========================================
  Hits          517      517              
- Misses        930      932       +2     
Impacted Files Coverage Δ
jobfunnel/backend/scrapers/base.py 38.99% <0.00%> (-0.50%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a86277...710e008. Read the comment docs.