PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.78k stars 210 forks source link

Bad url search keyword encoding #117

Closed PaulMcInnis closed 2 years ago

PaulMcInnis commented 3 years ago

Description

We currently pass keywords verbatim, even if they include “+” or other special characters, we should be encoding these so as not to disrupt the url formation.

Steps to Reproduce

  1. Search with any word containing +s such as “C++”

Expected behavior

We would get a query containing “%” encoded values in place of +s

Actual behavior

We build a search string with erroneous + chars that breaks the search query url (query is not as intended)

Environment

PaulMcInnis commented 3 years ago

We should consider using a library that construct urls for us which handles encoding

markkvdb commented 3 years ago

This problem is supposed to be fixed in #114

PaulMcInnis commented 2 years ago

Marking duplicate #80