markkvdb commented 3 years ago

Change program name to sys.argv[0] (default)

Description

Right now, the program name of JobFunnel in the CLI is "Job Search CLI." which is wrong. When calling funnel --help this results in a response as

usage: Job Search CLI. [-h] [--recover] {load,inline} ...

positional arguments:
  {load,inline}  Pass load with a YAML config or inline to pass args by CLI.
    load         Run using an existing configuration YAML.
    inline       Configure search query and data providers via CLI.

optional arguments:
  -h, --help     show this help message and exit
  --recover      Reconstruct a new master CSV file from all available cache
                 files.WARNING: this will replace all the statuses/etc in your
                 master CSV, it is intended for starting fresh / recovering
                 from a bad state.

Context of change

Please add options that are relevant and mark any boxes that apply.

[x] Software (software that runs on the PC)
[ ] Library (library that runs on the PC)
[ ] Tool (tool that assists coding development)
[ ] Other

Type of change

Please mark any boxes that apply.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Not necessary. Defaulted back to sys.argv[0] instead of custom name.

Checklist:

Please mark any boxes that have been completed.

[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.

markkvdb commented 3 years ago

Makes sense,

I think my_settings.yaml was included by mistake?

Yes it was 😄

codecov-io commented 3 years ago

Codecov Report

Merging #119 into master will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   35.74%   35.74%           
=======================================
  Files          22       22           
  Lines        1449     1449           
=======================================
  Hits          518      518           
  Misses        931      931

Impacted Files	Coverage Δ
jobfunnel/config/cli.py	`90.66% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf65ca7...0961bd3. Read the comment docs.

PaulMcInnis / JobFunnel

Change program name to sys.argv[0] (default) #119