search

PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.85k stars 215 forks source link

Studentbrad/icon #17

Closed studentbrad closed 5 years ago

studentbrad commented 5 years ago

After looking through numerous repositories I found that I really liked the ones with a simple image or icon. I think they make users feel that the repository is more developed. So, I made a quick icon. You can view it in the readme. If you feel that this doesn't belong in the repository I take no offense. 😃 Also feel free to give feedback or edit yourself. I included the image source.

studentbrad commented 5 years ago

The more I look at this the more I hate it. I'm not sure if I like this trend of putting icons in the readme file. Anyways feel free to review it but I believe this belongs in a website and not the software package.

PaulMcInnis commented 5 years ago

😥 i liked it tho

On Sat, Jul 6, 2019 at 6:51 PM Bradley Aaron Kohler < notifications@github.com> wrote:

Closed #17 https://github.com/PaulMcInnis/JobFunnel/pull/17.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/PaulMcInnis/JobFunnel/pull/17?email_source=notifications&email_token=AAYKY2KBH7Y45X2GHYMBXMTP6EOWRA5CNFSM4H6ULRG2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSLP2WWQ#event-2464131930, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYKY2KJCN6WPY6GIYZXE5TP6EOWRANCNFSM4H6ULRGQ .

--

  • Paul McInnis
itSeez commented 5 years ago

I liked it too, maybe we could have made the little company icons bigger and the overall icon smaller. But I think it looked very nice.

studentbrad commented 5 years ago

Okay I can change that. I was thinking maybe it should be a banner instead so we can replace the text Header with a banner image. Like: junfunnelo_banner

itSeez commented 5 years ago

I doesn't look like using companies' logos is something we can do: https://google.github.io/opencasebook/trademarks/

studentbrad commented 5 years ago

@itSeez That's unfortunate. Maybe we can go for a more simplistic icon then. Or we could just remove the company logos. Thoughts?

itSeez commented 5 years ago

How about an icon that depicts a cv or resume going into the funnel?

PaulMcInnis commented 5 years ago

how bout something like this image image

itSeez commented 5 years ago

Love the latest logo; thanks @studentbrad

itSeez commented 5 years ago

oh I think that images/jobfunnel.png still has the companies' logos.

studentbrad commented 5 years ago

@PaulMcInnis Yeah I thought about making something more simplistic. I've tried a few things but not sure if I liked them. The banner with the logo to the left is super popular.