PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.85k stars 215 forks source link

Travis CI: Use flake8 to find undefined names #40

Closed cclauss closed 4 years ago

cclauss commented 4 years ago

Add flake8 to Travis CI to find undefined names: https://flake8.pycqa.org/en/latest/user/error-codes.html

On the flake8 test selection, this PR does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect). Instead these tests are focus on runtime safety and correctness:

cclauss commented 4 years ago

https://travis-ci.com/PaulMcInnis/JobFunnel/builds/143221276#L213

PaulMcInnis commented 4 years ago

Sounds good, if I’m understanding this correctly we will need to make some formatting and style improvements to pass the build with these changes right?

Additonally, can you please rebase onto v2.0?

cclauss commented 4 years ago

this PR does not focus on "style violations"

PaulMcInnis commented 4 years ago

Ah sorry, I should have read that more carefully.

Ok. Seems like the build is passing now.

studentbrad commented 4 years ago

Can we merge this now? I see no issues.