Closed cclauss closed 4 years ago
Sounds good, if I’m understanding this correctly we will need to make some formatting and style improvements to pass the build with these changes right?
Additonally, can you please rebase onto v2.0?
this PR does not focus on "style violations"
Ah sorry, I should have read that more carefully.
Ok. Seems like the build is passing now.
Can we merge this now? I see no issues.
Add flake8 to Travis CI to find undefined names: https://flake8.pycqa.org/en/latest/user/error-codes.html
On the flake8 test selection, this PR does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect). Instead these tests are focus on runtime safety and correctness: