markkvdb commented 4 years ago

Path validate fix (Windows)

Description

The regex to check for valid log and filter lists used a regex which only works for UNIX systems. This pull request adds support for Windows.

Context of change

Please add options that are relevant and mark any boxes that apply.

[x] Software (software that runs on the PC)
[ ] Library (library that runs on the PC)
[ ] Tool (tool that assists coding development)
[ ] Other

Type of change

Please mark any boxes that apply.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

A windows user should test whether the changes no longer breaks at the validation step.

Checklist:

Please mark any boxes that have been completed.

[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.

studentbrad commented 4 years ago

Great! Thanks for doing this. We should avoid changing the single quotes to double quotes however unless there is a good reason. It’s not that either one is right or wrong, just that single quotes took precedence in this project for bs4 + regex purposes. Also, you are in a race for version 2.1.2 due to another PR. 😄