validate.py tests

[thebigG]

Pull Request Template

Hello everyone!

I tried describing my process as best I could below. Hope it's clear enough.

Description

Added tests on jobfunnel/tests/test_validate.py that test all functions in jobfunnel/config/validate.py. My thinking with tests was the following: Test each granular unit and then test those units as a whole. I also used attr_list in test_validate.py as a global pool for all invalid data to be used in the tests. These new tests have been added:

• tests for validating delay and min_delay
• tests for validating providers
• tests for validating max_listing_days
• tests for validating paths
• tests for validating region
• tests for validating domain
• tests for validating province

List any additional libraries that will be affected:

• jobfunnel/tests/test_validate.py List any developers that will be affected or those who you had merge conflicts with.

Context of change

Please add options that are relevant and mark any boxes that apply.

• [ ] Software (software that runs on the PC)
• [ ] Library (library that runs on the PC)
• [x] Tool (tool that assists coding development)
• [ ] Other

Type of change

Please mark any boxes that apply.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

• [x] Tested test_validate.py by itself
• [x] Tested the entire pytest suite

Checklist:

Please mark any boxes that have been completed.

• [x] I have performed a self-review of my own code.
• [x] I have commented my code, particularly in hard-to-understand areas.
• [ ] I have made corresponding changes to the documentation.
• [x] My changes generate no new warnings.
• [x] I have added tests that prove my fix is effective or that my feature works.
• [x] New and existing unit tests pass locally with my changes.
• [x] Any dependent changes have been merged and published in downstream modules.

[thebigG]

Nice job! +1 I will merge it to the master. Any idea what you want to as the next task?

Thanks! I really enjoyed playing around with testing so I'm thinking of writing tests for parser.pynext. It certainly looks a bit more complex but I think I can manage.