thebigG commented 4 years ago

Tools.py tests and conftest.py file

Hi everyone!

Hope you are all well and healthy!

Description

I have added tests for tools.py to test_tools.py. Followed the same approach as before; test each unit as isolated as possible from each other. I have also added a conftest.py file to our testing suite. This conftest.py file is loaded automatically when you run pytest. This is really useful because it allows to have things like fixtures, mocking code and any initialization we might need to do before tests all in one place. All kinds of testing automation can be done through this conftest.py file! This also allows us to avoid code duplication. For more info on pytest and all of its awesome features, you can read all of their awesome docs here. I have also refactored test_validate.py so that it uses our fixtures.

Context of change

Please add options that are relevant and mark any boxes that apply.

[ ] Software (software that runs on the PC)
[ ] Library (library that runs on the PC)
[x] Tool (tool that assists coding development)
[ ] Other

Type of change

Please mark any boxes that apply.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

[x] Tested test_validate.py by itself
[x] Tested test_tools.py by itself
[x] Tested the testing suite as a whole

Checklist:

Please mark any boxes that have been completed.

[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.

studentbrad commented 4 years ago

Looks good. Thank you for putting so much work into the unittests @thebigG.