PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.81k stars 212 forks source link

Testing for filters.py #68

Closed thebigG closed 4 years ago

thebigG commented 4 years ago

Testing for filters.py

Hello Everyone!

I hope you are all doing well!

Description

I wrote tests for filters.py. I also added a fixture that generates per_id of job_listings, hopefully the code and comments are clear enough on that one. I tried to isolate all testing units as much as I could from each other. List any developers that will be affected or those who you had merge conflicts with.

Context of change

Please add options that are relevant and mark any boxes that apply.

Type of change

Please mark any boxes that apply.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

Please mark any boxes that have been completed.

studentbrad commented 4 years ago

Your code is very clean and simplistic... I like 👍