studentbrad commented 4 years ago

Code Coverage

Description

Due to the work by @thebigG, we now have considerable code coverage that we may post the codecov badge.
Although code coverage is only about half, over the last few months it has improved from 19% to 49%; which I think is good news.

Important

Before merging, after @PaulMcInnis registers his GitHub account with codecov, I will have to update the codecov badge link.

Context of change

Please add options that are relevant and mark any boxes that apply.

[ ] Software (software that runs on the PC)
[ ] Library (library that runs on the PC)
[ ] Tool (tool that assists coding development)
[x] Other

Type of change

Please mark any boxes that apply.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

This has been tested in my forked repository. I have reviewed the code coverage results.

Checklist:

Please mark any boxes that have been completed.

[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.

PaulMcInnis commented 4 years ago

https://codecov.io/gh/PaulMcInnis/JobFunnel is sufficient information for codecov? I just signed up.

super cool that we're talking about code coverage for this project :)

studentbrad commented 4 years ago

@PaulMcInnis yes that is sufficient. I also added the links so that clicking on the badges will now show the build log. All I need now is your approval and we can merge.

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@60c2841). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #69   +/-   ##
=========================================
  Coverage          ?   49.62%           
=========================================
  Files             ?       18           
  Lines             ?     1991           
  Branches          ?        0           
=========================================
  Hits              ?      988           
  Misses            ?     1003           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60c2841...b50a1d4. Read the comment docs.

PaulMcInnis / JobFunnel

Studentbrad/codecov #69