PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.81k stars 212 forks source link

Forgot to add webdriver_manager to setup.py and missing comma was breaking selenium #74

Closed thebigG closed 4 years ago

thebigG commented 4 years ago

Pull Request Template

Description

I'm really sorry about this everyone. It looks like I forgot to add the webdriver_manager dependency to setup.py. And there was also a comma missing in the setup file that confused pip and did not install the selenium dependency.

Please also include relevant motivation and context. List any additional libraries that will be affected. List any developers that will be affected or those who you had merge conflicts with.

Context of change

Please add options that are relevant and mark any boxes that apply.

Type of change

Please mark any boxes that apply.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

Please mark any boxes that have been completed.

codecov-io commented 4 years ago

Codecov Report

Merging #74 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   46.96%   46.96%           
=======================================
  Files          11       11           
  Lines         990      990           
=======================================
  Hits          465      465           
  Misses        525      525           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37040f2...1c3bec6. Read the comment docs.