search

PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.81k stars 212 forks source link

Significant lag in CLI #76

Closed markkvdb closed 3 years ago

markkvdb commented 4 years ago

Significant lag in CLI

Description

Hi all,

Installing the latest version of JobFunnel and running funnel --help takes a few seconds when opening the first time. Later calls are slightly faster but are arguable still a tad slow.

I know I could have looked into the cause of the problem right now but I'm really low on time as of lately. If this issue still persists when I have more time I will come back to this (kind of a reminder for myself then).

Steps to Reproduce

  1. Fresh install of JobFunnel
  2. Call funnel --help
  3. Wait

Expected behavior

A few ms delay before showing CLI help information.

Actual behavior

Significant delay between function call and presented info.

Environment

thebigG commented 4 years ago

That's very strange. I doubt the changes I made will affect the --help prompt's speed. Will be looking into this further when I have time.

PaulMcInnis commented 4 years ago

I think this has to do with dependencies mostly, it may be avoided with doing more importing after we do arg-parsing.

It makes sense that it is slower since we have grown in dependencies

👍 for noticing this behavior that might discourage new users.

markkvdb commented 4 years ago

@thebigG it has not been caused by your recent changes. I think it has been here for a long time tbh. Yes, it probably has something to do with the parsing step but this is odd to me, since we are not doing that much parsing to begin with.

PaulMcInnis commented 4 years ago

python gets bogged down doing imports before it gets to parsing is my suspicion.

PaulMcInnis commented 3 years ago

CLI is acceptably fast at this point in time