[Fix Included] Google Chrome Driver undefined

PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.

MIT License

1.81k stars 212 forks source link

[Fix Included] Google Chrome Driver undefined #78

Closed phcreery closed 4 years ago

phcreery commented 4 years ago

Description

Google Chrome Driver not defined

Steps to Correct

Replace line 158 of jobfunnel/tools/tools.py webdriver.Chrome(ChromeDriverManager().install()) with driver = webdriver.Chrome(ChromeDriverManager().install()) so function get_webdriver() has a value to return.

Why not a pull request? Too small of a fix

Environment

Installed Commit: cb9f152
Operating system and version: Windows 10
Browser: Google Chrome

thebigG commented 4 years ago

I fixed this actually in my last PR #75 I was the one that forgot that assignment :sweat_smile: We're still in the middle of evaluating that PR so I hope we merge those changes soon! Thanks so much for bringing this to our attention!

phcreery commented 4 years ago

Awesome!! My apologies for not researching before submitting an issue. Will close.