PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.

MIT License

1.81k stars 212 forks source link

Add requirements.txt #89

Closed Zenahr closed 4 years ago

Zenahr commented 4 years ago

Pull Request Template

Description

Added requirements.txt for easier replication of development dependencies on local machines.

Context of change

[ ] Software (software that runs on the PC)
[ ] Library (library that runs on the PC)
[ ] Tool (tool that assists coding development)
[x] Other

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

Please mark any boxes that have been completed.

[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas. (not applicable)
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works. (not applicable)
[x] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

fixes #88

codecov-commenter commented 4 years ago

Codecov Report

Merging #89 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   58.34%   58.34%           
=======================================
  Files          13       13           
  Lines        1150     1150           
=======================================
  Hits          671      671           
  Misses        479      479

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aac4008...95603e3. Read the comment docs.

PaulMcInnis commented 4 years ago

Is it possible that we can avoid duplicating the requirements which are specified here? https://github.com/PaulMcInnis/JobFunnel/blob/aac400883916a2d455eb1bdd67feb8d44536a8df/setup.py#L7

I'd prefer they be specified once to avoid them mis-matching in the future.

PaulMcInnis commented 4 years ago

Ah, after reviewing this https://packaging.python.org/discussions/install-requires-vs-requirements/ I think it is ok to have requirements here as well, perhaps at a later date we can re-visit what is minimally needed vs what is needed for deployment.

Zenahr commented 4 years ago

Ah, after reviewing this https://packaging.python.org/discussions/install-requires-vs-requirements/ I think it is ok to have requirements here as well, perhaps at a later date we can re-visit what is minimally needed vs what is needed for deployment.

https://stackoverflow.com/a/20720019/12675239