search

PaulMcInnis / JobFunnel

Scrape job websites into a single spreadsheet with no duplicates.
MIT License
1.81k stars 212 forks source link

Improve test coverage #93

Open PaulMcInnis opened 3 years ago

PaulMcInnis commented 3 years ago

Description

A cost of releasing version 3.0.0 is a signifcant loss of test coverage.

Steps to Reproduce

git clone https://github.com/PaulMcInnis/JobFunnel
cd JobFunnel
pytest

Expected behavior

We should cover Jobfunnel and scraper get/set methods with unit testing via pyest. Existing codecov was set to around 60%

Coverage

I've added Notes for all the modules that need testing coverage in a kanban here: https://github.com/PaulMcInnis/JobFunnel/projects/2

Please keep this up-to-date so that we don't duplicate eachother's work on upping the test coverage :+1:

thebigG commented 3 years ago

Now that we have a solid foundation to test on, I'll start testing. Thanks for organizing the testing suite, it looks very neat now :+1:

Looked at the new readme and I'm wondering why there isn't instructions for developers to install JobFunnel in-palce like we had before?

PaulMcInnis commented 3 years ago

Just decided it was not necessesary, since that information is common to all python packages, available as pipe install -e

PaulMcInnis commented 3 years ago

In general I've stripped down the readme a lot in the interest of keeping it very simple for a new user to understand vs providing extra information, even if it's kinda useful like the in-place command

thebigG commented 3 years ago

That makes sense. A long readme can be intimidating for users who just want to use the tool.

PaulMcInnis commented 3 years ago

I'll leave this tagged help-wanted, jic others want to help out as well. I'll help with this as well after I get do 3.0.1 milestone.

I've added a kanban (todo/inprogress/done) thing over here so we can keep track of what people are working on so we dont duplicate eachother's work: https://github.com/PaulMcInnis/JobFunnel/projects/2