PaulMiami / reCAPTCHA

reCAPTCHA 2.0 for ASPNET Core
MIT License
134 stars 37 forks source link

Add support for reCAPTCHA Invisible #16

Open ernestogutierrez opened 7 years ago

ernestogutierrez commented 7 years ago

Google has added a new type of reCAPTCHA called Invisible.

See reCAPTCHA invisible documentation

egmfrs commented 7 years ago

@PaulMiami any idea on timescales for this enhancement?

PaulMiami commented 7 years ago

@egmfrs not sure I don't have much time for it at the moment

SanderDeclerck commented 7 years ago

Would you be accepting this as a pull request? I might have some time to add it.

dotnetshadow commented 7 years ago

@SanderDeclerck any luck with this?

SanderDeclerck commented 6 years ago

I should be able to create a pull request by the end of next week.

Outlook voor Android downloaden

On Mon, Dec 4, 2017 at 11:41 PM +0100, "dotnetshadow" notifications@github.com wrote:

@SanderDeclerck any luck with this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

dotnetshadow commented 6 years ago

@SanderDeclerck Awesome that would be great

SanderDeclerck commented 6 years ago

I did some tests. The validator does not need to change. The form data is the same as for the standard recaptcha. Only a new tag helper is needed.

Invisible recaptcha is bound to the submit button of a form. My proposal would be to create two taghelpers.

First one: <input for-recaptcha-form>:

<form id="my-form">
   <!-- some input fields -->
   <input for-recaptcha-form="my-form" type="submit" value="Submit form" />
</form>

Second one: <recaptcha-invisible-script form-id />:

@section Scripts {
    <recaptcha-invisible-script form-id="my-form" />
}

I could have it implemented by the end of next week.

dotnetshadow commented 6 years ago

@SanderDeclerck good work, sounds like it should be simple enough

SanderDeclerck commented 6 years ago

It has been implemented in the pull request I just created.

dotnetshadow commented 6 years ago

@SanderDeclerck thank you so much for this

Do you have a myget of your version?

SanderDeclerck commented 6 years ago

@dotnetshadow no, I don't have it on myget, and I don't plan to either.

Just wait a bit, give @PaulMiami some time to test and pull the changes.

If you want to use it earlier, then you could clone my fork and add a project dependency - or you could build the project and reference the dll manually.

I don't think there is much sense in creating a myget package just for a single build. One NuGet package for this project is enough: PaulMiami.AspNetCore.Mvc.Recaptcha. It makes it clear which version is the latest.

dotnetshadow commented 6 years ago

@SanderDeclerck yes you are right, I was just wondering from a testing point of view but yes I will wait thanks again for your efforts. Much appreciated

SanderDeclerck commented 6 years ago

You can always clone my fork if you wish to test. There's also a sample project in the solution.

AaronSadlerUK commented 6 years ago

@PaulMiami Is there a rough ETA on when this release will be out?

PaulMiami commented 6 years ago

@DJSADERS I have merge @SanderDeclerck #24 into a new branch, you can get it from there. I have identified some issues that I am working on, I don't want to give an eta as I don't really have time to work on it but I'll update this issue when I'll update the new branch...

coldacid commented 4 years ago

Is anything still happening with this?